New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use auto* for pointers #1662

Merged

awni merged 1 commit into ml-explore:main from frost-beta:msvc-auto-ptr

Dec 8, 2024

Contributor

zcbenz commented Dec 7, 2024

Refs #1513.

MSVC can not deduce auto to be a pointer and would complain delete p not working.


          Use auto* for pointers

b6d1d72

awni approved these changes

View reviewed changes

Member

awni left a comment

I think that might be incorrect in the spec, but it deduced it correctly somehow with clang.

awni merged commit 96986fb into ml-explore:main

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet